From: Paul Beesley <paul.beesley@arm.com>
Date: Wed, 6 Mar 2019 15:52:16 +0000 (+0000)
Subject: drivers: Remove TODO from io_fip.c
X-Git-Url: http://git.openwrt.org/%22https:/collectd.org//%22/%22https:/collectd.org/%22?a=commitdiff_plain;h=7d721816a3645024345ca138870baac4ab2f14d4;p=project%2Fbcm63xx%2Fatf.git

drivers: Remove TODO from io_fip.c

The comment suggests checking version numbers and
a checksum but there doesn't seem to be any usable
data for either of these.

For example, fip_toc_header_t doesn't contain any
version information and neither does fip_toc_entry_t.

As the function name "is_valid_header" suggests, this
function is not concerned with checksumming any of
the table of contents entries.

Change-Id: I8673ae5dd37793771760169f26b2f55c15fbf587
Signed-off-by: Paul Beesley <paul.beesley@arm.com>
---

diff --git a/drivers/io/io_fip.c b/drivers/io/io_fip.c
index d4771b51..eaaf0909 100644
--- a/drivers/io/io_fip.c
+++ b/drivers/io/io_fip.c
@@ -85,7 +85,6 @@ static inline int compare_uuids(const uuid_t *uuid1, const uuid_t *uuid2)
 }
 
 
-/* TODO: We could check version numbers or do a package checksum? */
 static inline int is_valid_header(fip_toc_header_t *header)
 {
 	if ((header->name == TOC_HEADER_NAME) && (header->serial_number != 0)) {